Skip to content

tests: xfail repro for stuck CLOSINGD_COMPLETE#9103

Open
ksedgwic wants to merge 1 commit into
ElementsProject:masterfrom
ksedgwic:test-closing-stuck
Open

tests: xfail repro for stuck CLOSINGD_COMPLETE#9103
ksedgwic wants to merge 1 commit into
ElementsProject:masterfrom
ksedgwic:test-closing-stuck

Conversation

@ksedgwic

Copy link
Copy Markdown
Collaborator

When a mutual close negotiation completes on a channel whose funding
tx never confirmed, the channel state is stuck. The signed close tx
is permanently invalid — its input is a 2-of-2 funding output that
does not exist on chain — so the state machine has no path from
CLOSINGD_COMPLETE to FUNDING_SPEND_SEEN / ONCHAIN. The channel
sits indefinitely with no cleanup.

The test asserts the desired post-fix behavior (state has moved beyond CLOSINGD_COMPLETE) and is marked @pytest.mark.xfail(strict=True).

reproduces #9102

@ksedgwic

Copy link
Copy Markdown
Collaborator Author

related to ksedgwic/clboss#312

@ksedgwic

Copy link
Copy Markdown
Collaborator Author

@ddustin added the "double-spent funding tx" modification we discussed, channel is stuck even though the funding can never commit ...

@ksedgwic ksedgwic force-pushed the test-closing-stuck branch from b7ff4ec to 093258e Compare June 22, 2026 19:16
@ksedgwic

Copy link
Copy Markdown
Collaborator Author

rebased onto master, simplified unit test and comments

…t funding

A user can be left with a channel wedged in a state that provably will
never resolve, with no transition to a sensible end state. The sequence:

How it gets stuck: BOLT 2 permits shutdown before channel_ready, so both
sides can finish a mutual close and store a signed close tx while still in
CHANNELD_AWAITING_LOCKIN; the channel reaches CLOSINGD_COMPLETE. That close
tx spends the funding output, so it only becomes usable once the funding tx
confirms. If the funding tx never confirms, the channel stays in
CLOSINGD_COMPLETE.

Why the state is held: while the funding inputs are unspent the
funding tx can still confirm (e.g. on rebroadcast), and if it does the
stored close resolves the channel normally, so the channel must be
kept until the funding is known dead.

After the double-spend is buried it is safe to clear: when a funding
input is spent by another tx and that spend is buried deep enough that a
reorg will not reverse it, the funding tx can never confirm. The funding
output will never exist, the channel can never resolve on chain, and it can
move to a clean end state.

This adds an xfail-strict reproducer that drives the channel into
CLOSINGD_COMPLETE behind a never-confirming funding tx, double-spends a
funding input, and asserts both edges: the channel must stay in
CLOSINGD_COMPLETE while the double-spend is shallow, and must reach a
resolved state once the spend is reorg-safe. The marker should be removed
once a fix exists.

Reproduces ElementsProject#9102.

Changelog-None
@ksedgwic ksedgwic force-pushed the test-closing-stuck branch from 093258e to df49c41 Compare June 22, 2026 19:32
@madelinevibes madelinevibes added this to the v26.09 milestone Jun 22, 2026
@ksedgwic ksedgwic mentioned this pull request Jun 22, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants